-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[dotnet] [bidi] Make input Origin as not nested
#15445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
User description
Motivation and Context
Contributes to #15407
Types of changes
Checklist
PR Type
Enhancement
Description
Refactored nested
Origintypes to standalone types.Updated JSON serialization logic for new
Origintypes.Improved code clarity by renaming and restructuring classes.
Changes walkthrough 📝
InputOriginConverter.cs
Update JSON serialization for refactored `Origin` typesdotnet/src/webdriver/BiDi/Communication/Json/Converters/InputOriginConverter.cs
Origintypes with standalone types.ElementOrigin.Origin.cs
Refactor `Origin` nested types into standalone recordsdotnet/src/webdriver/BiDi/Modules/Input/Origin.cs
Originnested types into standalone records.Viewport,Pointer, andElementtoViewportOrigin,PointerOrigin, andElementOrigin.ElementOriginto includeTypeproperty with internalvisibility.